Merge feature/standardize-logging into feature/v2-prep
Some checks failed
V2 CI/CD Pipeline / Pre-Flight Checks (push) Has been cancelled
V2 CI/CD Pipeline / Build & Dependencies (push) Has been cancelled
V2 CI/CD Pipeline / Code Quality & Linting (push) Has been cancelled
V2 CI/CD Pipeline / Unit Tests (100% Coverage Required) (push) Has been cancelled
V2 CI/CD Pipeline / Integration Tests (push) Has been cancelled
V2 CI/CD Pipeline / Performance Benchmarks (push) Has been cancelled
V2 CI/CD Pipeline / Decimal Precision Validation (push) Has been cancelled
V2 CI/CD Pipeline / Modularity Validation (push) Has been cancelled
V2 CI/CD Pipeline / Final Validation Summary (push) Has been cancelled
Some checks failed
V2 CI/CD Pipeline / Pre-Flight Checks (push) Has been cancelled
V2 CI/CD Pipeline / Build & Dependencies (push) Has been cancelled
V2 CI/CD Pipeline / Code Quality & Linting (push) Has been cancelled
V2 CI/CD Pipeline / Unit Tests (100% Coverage Required) (push) Has been cancelled
V2 CI/CD Pipeline / Integration Tests (push) Has been cancelled
V2 CI/CD Pipeline / Performance Benchmarks (push) Has been cancelled
V2 CI/CD Pipeline / Decimal Precision Validation (push) Has been cancelled
V2 CI/CD Pipeline / Modularity Validation (push) Has been cancelled
V2 CI/CD Pipeline / Final Validation Summary (push) Has been cancelled
Standardized logging to use go-ethereum/log exclusively, removing slog dependency. ## Summary Replaced slog.Logger with go-ethereum/log.Logger throughout the sequencer reader for consistency with Ethereum ecosystem tooling. ## Benefits - Single logging framework (no mixing) - Consistent with go-ethereum ecosystem - Simpler dependency tree - Compatible API 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -3,7 +3,6 @@ package sequencer
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"log/slog"
|
||||
"math/big"
|
||||
"sync"
|
||||
"time"
|
||||
@@ -63,7 +62,7 @@ func DefaultReaderConfig() *ReaderConfig {
|
||||
// Reader reads pending transactions from the Arbitrum sequencer
|
||||
type Reader struct {
|
||||
config *ReaderConfig
|
||||
logger *slog.Logger
|
||||
logger log.Logger
|
||||
|
||||
// Components
|
||||
parsers parsers.Factory
|
||||
@@ -102,7 +101,7 @@ func NewReader(
|
||||
poolCache cache.PoolCache,
|
||||
detector *arbitrage.Detector,
|
||||
executor *execution.Executor,
|
||||
logger *slog.Logger,
|
||||
logger log.Logger,
|
||||
) (*Reader, error) {
|
||||
if config == nil {
|
||||
config = DefaultReaderConfig()
|
||||
@@ -117,13 +116,13 @@ func NewReader(
|
||||
// Create swap filter with pool cache
|
||||
swapFilter := NewSwapFilter(&SwapFilterConfig{
|
||||
SwapChannelSize: config.BufferSize,
|
||||
Logger: loggerAdapter(logger),
|
||||
Logger: logger,
|
||||
PoolCacheFile: "data/discovered_pools.json",
|
||||
})
|
||||
|
||||
return &Reader{
|
||||
config: config,
|
||||
logger: logger.With("component", "sequencer_reader"),
|
||||
logger: logger.New("component", "sequencer_reader"),
|
||||
parsers: parsers,
|
||||
validator: validator,
|
||||
poolCache: poolCache,
|
||||
@@ -136,13 +135,6 @@ func NewReader(
|
||||
}, nil
|
||||
}
|
||||
|
||||
// loggerAdapter converts slog.Logger to log.Logger interface
|
||||
func loggerAdapter(l *slog.Logger) log.Logger {
|
||||
// For now, create a simple wrapper
|
||||
// TODO: Implement proper adapter if needed
|
||||
return log.Root()
|
||||
}
|
||||
|
||||
// Start starts the sequencer reader
|
||||
func (r *Reader) Start(ctx context.Context) error {
|
||||
r.logger.Info("starting sequencer reader",
|
||||
@@ -320,7 +312,7 @@ func (r *Reader) readMessages(ctx context.Context, conn *websocket.Conn) error {
|
||||
func (r *Reader) worker(ctx context.Context, id int) {
|
||||
defer r.wg.Done()
|
||||
|
||||
logger := r.logger.With("worker", id)
|
||||
logger := r.logger.New("worker", id)
|
||||
|
||||
for {
|
||||
select {
|
||||
|
||||
Reference in New Issue
Block a user